extended for arbitrary number of halos #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-costa
reviewed
Mar 4, 2024
Owner
p-costa
left a comment
p-costa
left a comment
There was a problem hiding this comment.
Nice addition, thanks Sanath! Just some minor suggestions to keep the same default behavior as the previous version.
| real(rp), parameter, dimension(3) :: l = [1.5_rp,3._rp,1._rp] | ||
| integer , parameter, dimension(3) :: ni = [128,256, 72] | ||
| integer , parameter, dimension(3) :: no = [256,512,144] | ||
| real(rp), parameter, dimension(3) :: l = [8._rp,4._rp,2._rp] |
Owner
There was a problem hiding this comment.
No need to change these 3 lines (I guess you picked it from your use case).
Owner
There was a problem hiding this comment.
Suggested change
| real(rp), parameter, dimension(3) :: l = [8._rp,4._rp,2._rp] | |
| real(rp), parameter, dimension(3) :: l = [1.5_rp,3._rp,1._rp] |
Co-authored-by: Pedro Costa <[email protected]>
Co-authored-by: Pedro Costa <[email protected]>
Co-authored-by: Pedro Costa <[email protected]>
p-costa
reviewed
Mar 5, 2024
| integer , parameter, dimension(3) :: ni = [128,256, 72] | ||
| integer , parameter, dimension(3) :: no = [256,512,144] | ||
| real(rp), parameter, dimension(3) :: l = [8._rp,4._rp,2._rp] | ||
| integer , parameter, dimension(3) :: ni = [256,128,180] |
Owner
There was a problem hiding this comment.
Suggested change
| integer , parameter, dimension(3) :: ni = [256,128,180] | |
| integer , parameter, dimension(3) :: ni = [128,256, 72] |
p-costa
reviewed
Mar 5, 2024
| integer , parameter, dimension(3) :: no = [256,512,144] | ||
| real(rp), parameter, dimension(3) :: l = [8._rp,4._rp,2._rp] | ||
| integer , parameter, dimension(3) :: ni = [256,128,180] | ||
| integer , parameter, dimension(3) :: no = [512,128,200] |
Owner
There was a problem hiding this comment.
Suggested change
| integer , parameter, dimension(3) :: no = [512,128,200] | |
| integer , parameter, dimension(3) :: no = [256,512,144] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a variable nh in common to define the number of halos.