[bugfix] Issue with Method Filter in Coercer Command, fixes #101#102
Merged
p0dalirius merged 1 commit intomasterfrom Jan 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the method filtering logic where multiple filters were incorrectly combined using OR logic instead of AND logic. The fix ensures that when both method and protocol filters are specified, an instance must match both filters to be included.
Key Changes:
- Refactored
method_matches_filterto use AND logic when both method and protocol filters are present - Added early returns with
breakstatements for improved performance - Improved code readability with explicit variable names and clearer logic flow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+39
to
+40
| method_match = True if not has_method_filters else False | ||
| protocol_match = True if not has_protocol_filters else False |
There was a problem hiding this comment.
The ternary operator here can be simplified for better readability. Instead of True if not has_method_filters else False, you can use not has_method_filters directly. The same applies to the protocol_match initialization.
Suggested change
| method_match = True if not has_method_filters else False | |
| protocol_match = True if not has_protocol_filters else False | |
| method_match = not has_method_filters | |
| protocol_match = not has_protocol_filters |
p0dalirius
deleted the
fix-101-Issue-with-Method-Filter-in-Coercer-Command
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.