Open
Conversation
fruffy
added
the
infrastructure
Collaborator
|
The bazel formatting test fails |
smolkaj
requested changes
Jan 8, 2026
Member
smolkaj
left a comment
smolkaj
left a comment
There was a problem hiding this comment.
LGTM modulo running the formatting script and minor comments. Thanks for the PR!
| @@ -0,0 +1,3 @@ | |||
| exports_files([ | |||
Member
There was a problem hiding this comment.
While we're at it, can we use bzl_library?
Example:
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
bzl_library(
name = "defs",
srcs = ["defs.bzl"],
deps = [
":utils", # defs.bzl loads utils.bzl
"//external_pkg:rules",
],
visibility = ["//visibility:public"],
)
bzl_library(
name = "utils",
srcs = ["utils.bzl"],
)
| @@ -0,0 +1,3 @@ | |||
| exports_files([ | |||
| "p4_library.bzl", | |||
Member
There was a problem hiding this comment.
Don't we also need to declare our other .bzl files for flex and bison etc? Why does this even compile?
Author
There was a problem hiding this comment.
Agreed .
I will use bzl_library and declare the other bazel files ( flex , bison and others )
Member
|
What's the status on this PR? |
Member
|
Are you still planing to submit this or shall we close it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates p4c’s Bazel setup so it works properly with Bazel bzlmod.
What is changed
bazel/folder//bazel:...formatWhy this change
Without this, p4c Bazel rules cannot be used correctly when bzlmod is enabled.
This change does not affect existing WORKSPACE based builds.
No functional code changes are included.