Open
Conversation
ajjackson
force-pushed
the
release-2.0.0
branch
from
c058e3e to
fdf941c
Compare
Contributor
This file is way too large and hard to navigate
At this point we may as well finish the job and make this file a namespace only.
This is theoretically a breaking change, but going into 2.0 so no big deal. Still it doesn't seem worth advertising?
oerc0122
reviewed
Apr 21, 2026
Collaborator
oerc0122
left a comment
oerc0122
left a comment
There was a problem hiding this comment.
Code looks good overall but failing. Many of these may not want to go in this PR, since I think we want this to mostly be a transcription, but can get away with some more modern Python features for potentially better expression.
Co-authored-by: Jacob Wilkins <46597752+oerc0122@users.noreply.github.com>
This was referenced Apr 21, 2026
Co-authored-by: Jacob Wilkins <46597752+oerc0122@users.noreply.github.com>
General principle is to make parameter types permissive, but we _know_ this is coming from argparse and users aren't supposed to play with it.
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In support of work on mccabe complexity.
It is very difficult to review code that moves and changes simultaneously, so here we separately implement the code movement of this rather large utility module into private submodules.