Use matching compose for testing EPEL-10-branched builds #509
Conversation
Signed-off-by: Nikola Forró <[email protected]>
Summary of ChangesHello @nforro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the testing setup for EPEL-10-branched builds by modifying the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the testing configuration in .packit.yaml for EPEL-10 builds. It replaces the generic epel-10-all target with more explicit targets for CentOS-Stream-10 and RHEL-10.1-Nightly, and enables the use of an internal testing farm. While this change improves clarity, I've identified a potential issue where the specified RHEL 10 distro name (RHEL-10.1-Nightly) might not be correctly recognized by the existing test plans, which could lead to test failures.
| rhel+epel-10-x86_64: | ||
| # Y-release needs to be bumped when epel-10-branched advances | ||
| distros: [RHEL-10.1-Nightly] |
There was a problem hiding this comment.
The distro RHEL-10.1-Nightly is used here, but the adjust rule in plans/full.fmf for RHEL 10 will not match this. The condition is when: "distro == rhel-10", which expects an exact match. This will cause the prepare step that installs flexmock via pip to be skipped, likely leading to test failures in the full plan.
To fix this, you should probably update plans/full.fmf to correctly match this distro. For example, you could use a regex match:
- when: "distro ~= rhel-10 or distro == centos-10 or distro == centos-stream-10"Or add the specific distro name to the condition. Since plans/full.fmf is not in this PR, you might need to create a separate PR for it or add it to this one.
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 59s |
|
/packit test |
|
/packit-stg test |
No description provided.