Support Laravel 5.4+ - #5
Open
cschalenborgh wants to merge 1 commit into
Open
Conversation
Fixes this issue: ``` php artisan vendor:publish --provider="Padosoft\AffiliateNetwork\AffiliateNetworkServiceProvider" Symfony\Component\Debug\Exception\FatalThrowableError : Call to undefined method Illuminate\Foundation\Application::share() ```
There was a problem hiding this comment.
Pull request overview
Updates the package’s Laravel service provider registration to be compatible with Laravel 5.4+, where Application::share() is no longer available.
Changes:
- Replaces the deprecated
$this->app->share(...)binding with a$this->app->singleton(...)binding in the service provider.
Comments suppressed due to low confidence (1)
src/AffiliateNetworkServiceProvider.php:41
- The container binding here registers a singleton for
Connection::class, but this class isn’t imported/defined in this package (soConnection::classresolves toPadosoft\AffiliateNetwork\Connectionand will fatally error). It also doesn’t match the instance being returned (new NetworkManager()) or the subsequent alias/provides entries that referenceNetworkManager. Bind the singleton under'NetworkManager'(orNetworkManager::class) and alignalias()/provides()to the same abstract.
$this->app->singleton(Connection::class, function ($app) {
return new NetworkManager();
});
$this->app->alias('NetworkManager', NetworkManager::class);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
share() is removed in Laravel 5.4.
Here's the fix: