Feature: Add page titles to most routes#227
Open
queenvictoria wants to merge 3 commits intopages-cms:developmentfrom
Open
Feature: Add page titles to most routes#227queenvictoria wants to merge 3 commits intopages-cms:developmentfrom
queenvictoria wants to merge 3 commits intopages-cms:developmentfrom
Conversation
Member
|
I've had a quick look, I think I can give it a try later on this week when I prepare the new release. I may reimplement myself as there's been a fair amount of changes to the codebase in the past 2 weeks. |
Member
|
@queenvictoria Much appreciated. Could you rework this PR to be against the https://github.com/pages-cms/pages-cms/blob/main/CONTRIBUTING.md |
queenvictoria
force-pushed
the
feature/head-titles
branch
from
fe461f4 to
1ffefc8
Compare
Author
|
That's updated thanks @hunvreus . Please note: the first file has been disabled as it causes a router error. I'm not sure why but perhaps you can look: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found it difficult to navigate the router history while testing a site as every page is titled "Pages CMS".
I've had a stab at creating more meaningful page titles. I've had to disable the page title for the
collection/[name]route as it prevented navigation to child routes. And I've not loaded content to get the correct title opting instead for the last fragment of the path. Regardless--I now find this makes navigating back through the history more usable.