feat(format): arch-constraints-v1 + cooperative-matrix-gemm-v1 6-gate PARTIAL discharge#1394
Closed
noahgift wants to merge 2 commits into
Closed
feat(format): arch-constraints-v1 + cooperative-matrix-gemm-v1 6-gate PARTIAL discharge#1394noahgift wants to merge 2 commits into
noahgift wants to merge 2 commits into
Conversation
… PARTIAL discharge Bundles two sister contracts in one verdict module: arch-constraints-v1 (FALSIFY-ARCH-CONSTRAINTS-001..003): - ARCH-001: model-family yamls match this contract (no drift) - ARCH-002: no unknown enum values across families - ARCH-003: DeepSeek eps == 1e-6 (regression guard, was 1e-5) cooperative-matrix-gemm-v1 (FALSIFY-COOP-001..003): - COOP-001: |coop - tiled| < 1e-3 elementwise - COOP-002: coop GFLOPS strictly > 2 × tiled GFLOPS - COOP-003: fallback path used when coop unavailable, no crash ## Five Whys 1. Why bundle these two contracts? Both peripheral, span the per-architecture constraints + cooperative-matrix coverage band; one verdict module captures both without duplicate provenance pin overhead. 2. Why does this block ship? Coverage % cannot move while these peripheral contracts are unbound at PARTIAL_ALGORITHM_LEVEL. 3. Why exact-equality for ARCH-003 (DeepSeek eps)? The regression class is "someone reverts to the wrong default 1e-5." Tolerance would mask the exact bug the gate exists to catch — the contract says "1e-6, not 1e-5" with no float-tolerance window. 4. Why strict `>` for COOP-002 (not `>=`)? Per the contract formula: "coop GFLOPS > 2 * tiled GFLOPS." Equality at exactly 2× is the boundary where coop is doing the same work for the same speed (no benefit). Strict `>` catches the regression class "coop matches tiled but doesn't beat it." 5. Why a 4-state truth table for COOP-003 (supported × used_coop × used_tiled × crashed)? The spec says fallback applies only when coop_supported is false. Modeling all 4 dimensions catches the regression class "coop dispatched on unsupported HW → crash" AND the inverse "tiled dispatched on supported HW → wasted perf." Adds 24 unit tests including a 6-bucket throughput-ratio sweep on COOP-002. Realistic-healthy walks the canonical post-fix state; pre-fix walks 6 simultaneous regressions across both contracts. No runtime % shift; algorithm-level coverage advances by 6 gates.
noahgift
force-pushed
the
feat/arch-coop-001-006-partial-discharge
branch
from
0683e1a to
d732d34
Compare
Contributor
Author
auto-merge was automatically disabled
May 12, 2026 09:20
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles two sister contracts in one verdict module:
arch-constraints-v1(FALSIFY-ARCH-CONSTRAINTS-001..003): family consistency, enum exhaustive, DeepSeek eps regressioncooperative-matrix-gemm-v1(FALSIFY-COOP-001..003): parity, throughput, fallback24 unit tests. Algorithm-level coverage advances by 6 gates; runtime ship % unchanged.
Gates bound
|coop - tiled| < 1e-3elementwisecoop GFLOPS > 2 × tiled GFLOPS(strict)!coop_supported, no crashFive Whys
See commit message — captures exact-equality for ARCH-003, strict
>for COOP-002, and 4-state truth table for COOP-003.Test plan
cargo test -p aprender-core --lib arch_coop— 24 passed🤖 Generated with Claude Code