Skip to content

ci: install GUI system libraries on intel-clean-room runners#1

Merged
noahgift merged 4 commits into
mainfrom
fix/ci-system-deps
Apr 25, 2026
Merged

ci: install GUI system libraries on intel-clean-room runners#1
noahgift merged 4 commits into
mainfrom
fix/ci-system-deps

Conversation

@noahgift
Copy link
Copy Markdown
Contributor

Summary

  • intel-clean-room runners lack X11/GTK4/FLTK dev headers, so fltk-sys's bundled cfltk C++ build fails with 'fl_xid' was not declared and 'Window' does not name a type
  • Add an apt-get install step to clippy/test/contracts/coverage jobs that installs the package set documented in README.md
  • fmt + deny don't compile, so they stay unchanged
  • Subsequent runs on the same runner are apt no-ops

Test plan

  • First run #24928048577 failed at fltk-sys C++ build with missing X11 headers
  • CI on this PR completes all 6 jobs (fmt, clippy, test, contracts, coverage, deny) green
  • gate aggregator passes

🤖 Generated with Claude Code

noahgift and others added 4 commits April 25, 2026 11:48
The intel-clean-room runners are sandboxed and lack X11 / GTK4 / FLTK
dev headers. fltk-sys's bundled cfltk C++ build needs Xlib's `Window`
type and Mesa GL headers at compile time, which surfaces as `'fl_xid'
was not declared` and `'Window' does not name a type` errors.

Add a pre-build step to clippy / test / contracts / coverage jobs that
installs the package set already documented in README.md for FLTK and
GTK4. fmt and deny don't compile, so they stay unchanged. Subsequent
runs on the same runner are no-ops once apt has the packages.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Multiple jobs land on the same intel-clean-room host and contend on
  /var/lib/apt/lists/lock when they run apt-get update in parallel.
  Switch each install step to `apt-get -o DPkg::Lock::Timeout=300`
  so apt waits up to 5 minutes for the lock instead of failing.
- Add assets/hero.svg + hero.png and reference it from README so the
  landing page actually shows what the five framework demos look like.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
DPkg::Lock::Timeout only covers /var/lib/dpkg/lock-frontend, not
/var/lib/apt/lists/lock — and the latter is what concurrent
intel-clean-room jobs collide on. Wrap apt-get update+install in a
30-attempt retry loop with 10s gaps so the second-arriving jobs wait
out the first job's apt-get update instead of failing fast.

Pull the install into .github/actions/setup-deps so each consumer job
is one line (`uses: ./.github/actions/setup-deps`) instead of repeating
the package list four times.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The 8 intel-clean-room runners share /home/noah/data/actions-runner/_work/
on the host filesystem. When two jobs from the same workflow (e.g. clippy
and test, or contracts and deny) land on the same runner, they trample
each other's target/debug/deps/, producing rustc "couldn't create a temp
dir" errors and fltk-sys cmake "opening dependency file ... No such file
or directory" failures.

Pin each compile job's target directory to ${{ runner.temp }} (auto-
isolated per job, auto-cleaned by the runner) so concurrent jobs on the
same host stay out of each other's way. fmt and deny don't compile, so
they don't need the override.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@noahgift noahgift force-pushed the fix/ci-system-deps branch from b7c6644 to e51e238 Compare April 25, 2026 10:07
@noahgift noahgift merged commit bcc49db into main Apr 25, 2026
7 checks passed
@noahgift noahgift deleted the fix/ci-system-deps branch April 25, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant