fix(docs): correct View source URLs for acronym-prefixed examples#8054
Open
Abdeltoto wants to merge 1 commit intopalantir:developfrom
Open
fix(docs): correct View source URLs for acronym-prefixed examples#8054Abdeltoto wants to merge 1 commit intopalantir:developfrom
Abdeltoto wants to merge 1 commit intopalantir:developfrom
Conversation
Use lodash camelCase to map PascalCase export names to on-disk .tsx filenames (e.g. HTMLSelectExample -> htmlSelectExample). Extract exampleExportNameToSourceFileName with unit tests. Add Vitest for docs-app and assert isReactNodeEmpty(false) in core utils tests. Fixes palantir#6296. Made-with: Cursor
Generate changelog in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6296
Checklist
exampleSourceFileName.test.ts,isReactNodeEmpty(false)in core)Changes proposed in this pull request
HTMLSelectExamplewere turned intohTMLSelectExample.tsxby lowercasing only the first character. We now derive filenames withlodash/camelCasevia a small helperexampleExportNameToSourceFileName, so links resolve tohtmlSelectExample.tsxand other acronym-leading names behave consistently.@blueprintjs/docs-app(node environment) for the helper; one extra assertion inutils.test.tsxforisReactNodeEmpty(false).Reviewers should focus on
develop.pnpm --filter @blueprintjs/docs-app testand existing core test suites.