Skip to content

Conversation

@davidpaquin
Copy link
Contributor

@davidpaquin davidpaquin commented Oct 9, 2025

See the README changes for an example.

Some things to note:

  • Validation for links was moved from defineLink.ts to convertLink.ts to solve some circular dependency problems between derived datasources, links, and objects
  • There is a break in defineObject where instead of a datasource? field, there is now a datasources field that is an array of datasource definitions. A default dataset source will still be produced if a "base datasource" is not specified (dataset, stream, RV)
  • There's still some validation that we could do, like making sure that the types of the current and foreign properties are compatible (e.g. right now we allow doubles to be collected into a list of integers, which we probably shouldn't?)

Copy link
Contributor

@aep000 aep000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets ship it

@bulldozer-bot bulldozer-bot bot merged commit 7fd788b into main Oct 27, 2025
8 checks passed
@bulldozer-bot bulldozer-bot bot deleted the dp/derived branch October 27, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants