Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metrics/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ module github.com/palantir/pkg/metrics
go 1.24.0

require (
github.com/palantir/go-metrics v1.1.1
github.com/palantir/go-metrics v1.1.2-0.20250702225129-c6f3e150f585
github.com/palantir/pkg v1.1.0
github.com/palantir/pkg/objmatcher v1.1.0
github.com/pkg/errors v0.8.1
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.10.0
)

Expand Down
8 changes: 4 additions & 4 deletions metrics/go.sum
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/palantir/go-metrics v1.1.1 h1:YL/UmptBjrC6iSCTVr7vfuIcjL0M359Da3/gBGNny10=
github.com/palantir/go-metrics v1.1.1/go.mod h1:fRkuipBnsI4nD8Vd9UNcrUJvD8Y0wOJMSbicygcBrGs=
github.com/palantir/go-metrics v1.1.2-0.20250702225129-c6f3e150f585 h1:zMElUPb/81H1n/iCWohy8FJ74O6rNe7o5r9OYz8Lqnc=
github.com/palantir/go-metrics v1.1.2-0.20250702225129-c6f3e150f585/go.mod h1:fRkuipBnsI4nD8Vd9UNcrUJvD8Y0wOJMSbicygcBrGs=
github.com/palantir/pkg v1.1.0 h1:0EhrSUP8oeeh3MUvk7V/UU7WmsN1UiJNTvNj0sN9Cpo=
github.com/palantir/pkg v1.1.0/go.mod h1:KC9srP/9ssWRxBxFCIqhUGC4Jt7OJkWRz0Iqehup1/c=
github.com/palantir/pkg/objmatcher v1.1.0 h1:bh/Set1mIL3sEJKIBbNr3afPg0PrvhPKY6deyGwGhZs=
github.com/palantir/pkg/objmatcher v1.1.0/go.mod h1:sUFipHgtqogNOs9uir4Fbu8Nu+n3qTAEL2vfghIiwZ0=
github.com/pkg/errors v0.8.1 h1:iURUrRGxPUNPdy5/HRSm+Yj6okJ6UtLINN0Q9M4+h3I=
github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stathat/go v1.0.0/go.mod h1:+9Eg2szqkcOGWv6gfheJmBBsmq9Qf5KDbzy8/aYYR0c=
Expand Down
16 changes: 16 additions & 0 deletions metrics/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package metrics

import (
"context"
"fmt"
"strings"
"sync"
"time"
Expand Down Expand Up @@ -261,6 +262,9 @@ func (r *childRegistry) Each(f MetricVisitor) {
}

func (r *childRegistry) Unregister(name string, tags ...Tag) {
if strings.Contains(name, "signals.expected-state.beta.healthstatus.node.value.status") && strings.Contains(name, "rubix-node-agent") {
fmt.Println("Unregistering Metric...", name, tags)
}
r.root.Unregister(r.prefix+name, append(r.tags, tags...)...)
}

Expand Down Expand Up @@ -324,6 +328,9 @@ func (r *rootRegistry) Unregister(name string, tags ...Tag) {

// This must happen after the registry Unregister() above to preserve the correctness guarantees in Each()
r.idToMetricMutex.Lock()
if strings.Contains(name, "signals.expected-state.beta.healthstatus.node.value.status") && strings.Contains(name, "rubix-node-agent") {
fmt.Println("Unregistering Metric from idToMetricWithTags...", name, tags, metricID)
}
delete(r.idToMetricWithTags, metricID)
r.idToMetricMutex.Unlock()
}
Expand All @@ -333,6 +340,9 @@ func (r *rootRegistry) Counter(name string, tags ...Tag) metrics.Counter {
}

func (r *rootRegistry) Gauge(name string, tags ...Tag) metrics.Gauge {
if strings.Contains(name, "signals.expected-state.beta.healthstatus.node.value.status") && strings.Contains(name, "rubix-node-agent") {
fmt.Println("Registering Gauge...", name, tags)
}
return metrics.GetOrRegisterGauge(r.registerMetric(name, tags), r.registry)
}

Expand Down Expand Up @@ -374,6 +384,9 @@ func getOrRegisterHistogram(name string, r metrics.Registry) metrics.Histogram {
}

func (r *rootRegistry) registerMetric(name string, tags Tags) string {
if strings.Contains(name, "signals.expected-state.beta.healthstatus.node.value.status") && strings.Contains(name, "rubix-node-agent") {
fmt.Println("Registering Metric...", name, tags)
}
sortedTags := newSortedTags(tags)
metricID := toMetricTagsID(name, sortedTags)
r.idToMetricMutex.Lock()
Expand All @@ -382,6 +395,9 @@ func (r *rootRegistry) registerMetric(name string, tags Tags) string {
tags: sortedTags,
}
r.idToMetricMutex.Unlock()
if strings.Contains(name, "signals.expected-state.beta.healthstatus.node.value.status") && strings.Contains(name, "rubix-node-agent") {
fmt.Println("Metric registered...", name, tags, metricID)
}
return string(metricID)
}

Expand Down
2 changes: 2 additions & 0 deletions metrics/vendor/github.com/palantir/go-metrics/.travis.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion metrics/vendor/github.com/palantir/go-metrics/gauge.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 45 additions & 1 deletion metrics/vendor/github.com/palantir/go-metrics/registry.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 3 additions & 8 deletions metrics/vendor/github.com/pkg/errors/.travis.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions metrics/vendor/github.com/pkg/errors/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion metrics/vendor/github.com/pkg/errors/errors.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading