Skip to content

fix pinging for fake clients - #674

Merged
sh4nks merged 2 commits into
pallets-eco:mainfrom
john0isaac:fix/ping-init-issues
Aug 22, 2026
Merged

fix pinging for fake clients#674
sh4nks merged 2 commits into
pallets-eco:mainfrom
john0isaac:fix/ping-init-issues

Conversation

@john0isaac

Copy link
Copy Markdown
Contributor

Possibly fix tests

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@john0isaac

Copy link
Copy Markdown
Contributor Author

@sh4nks it's ready for merging.

Turns out pinging clients in init is problematic. I added it as an opt-in behaviour hidden behind check_connection and disabled by default.
pallets-eco/cachelib#508

@sh4nks

sh4nks commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

@sh4nks
sh4nks merged commit 2f993e7 into pallets-eco:main Aug 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants