Skip to content

Conversation

pandyah5
Copy link

@pandyah5 pandyah5 commented Jun 12, 2024

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jul 13, 2024
Copy link
Member

@asishm asishm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Bug fixes almost always need tests

@pandyah5
Copy link
Author

Thanks @asishm. I'll add a test soon!

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series.combine_first replaces None with NaN at index not provided by other
3 participants