BUG: Fix logical method Non 1D Extension Arrays #61869
Conversation
|
Now, ExtensionArrays handle these cases like NumPy arrays do by returning NotImplemented when they can’t perform the operation. |
tisjayy
changed the title
tisjayy
changed the title
| @@ -379,7 +379,7 @@ def _logical_method(self, other, op): # type: ignore[override] | |||
| elif is_list_like(other): | |||
| other = np.asarray(other, dtype="bool") | |||
| if other.ndim > 1: | |||
| raise NotImplementedError("can only perform ops with 1-d structures") | |||
| return NotImplemented | |||
There was a problem hiding this comment.
can you add tests that this fixes the relevant bug
There was a problem hiding this comment.
Just to clarify, do you want the fallback behavior to remain as returning NotImplemented (as in my current code), or some other behavior?
Also, would you prefer the test cases go in a new file like pandas/tests/extension/test_logical_ops_2d_extension.py, or is there a more appropriate existing file?
Appreciate your guidance!
There was a problem hiding this comment.
try writing a test matching the OP example in the linked issue
id put it in tests/arithmetic/test_numeric.py
There was a problem hiding this comment.
what do you think of this? I'll add it and check on tests later.
There was a problem hiding this comment.
returning NotImplemented is not the thing we care about. we care about the end result of the arithmetic operation.
There was a problem hiding this comment.
We'd expect np_array * ea_array to return an ExtensionArray
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.