BUG: Fix inconsistency with DateOffset near DST #61870
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/_libs/tslibs/offsets.pyx
Outdated
| if not kwds: | ||
| from dateutil.relativedelta import relativedelta | ||
|
|
||
| # GH 45643/45890: (historically) defaults to 1 day |
There was a problem hiding this comment.
the comment here needs adjusting?
|
|
||
| @pytest.mark.parametrize("n", [-1, 1, 3]) | ||
| def test_construct_int_arg_no_kwargs_assumed_days(n): | ||
| from dateutil.relativedelta import relativedelta |
There was a problem hiding this comment.
can this go at the top of the file
| def test_construct_int_arg_no_kwargs_assumed_days(n): | ||
| from dateutil.relativedelta import relativedelta | ||
|
|
||
| # GH 45890, 45643 |
|
can you add a whatsnew note |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
|
||
| import warnings | ||
|
|
||
| from dateutil.relativedelta import relativedelta |
There was a problem hiding this comment.
is this imported at top-level anywhere else in the repo? not sure but we might be delaying this import to improve import pandas as pd speed
There was a problem hiding this comment.
On main it is a localized import in this file on line 328
if all(k in kwds_use_relativedelta for k in kwds_no_nanos):
from dateutil.relativedelta import relativedelta
return relativedelta(**kwds_no_nanos), True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type annotations to new arguments/methods/functions.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This fix ensures that
pd.offsets.DateOffset(1)andpd.offsets.DateOffset(days=1)return the same value near a DST transition.