Skip to content

DOC: Clarify to_numeric behavior for numeric dtypes #61904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chilin0525
Copy link
Contributor

@chilin0525 chilin0525 changed the title Doc: Clarify to_numeric behavior for numeric dtypes DOC: Clarify to_numeric behavior for numeric dtypes Jul 19, 2025
Comment on lines 61 to 62
to obtain other dtypes. Numeric dtypes include all dtypes that have
the `_is_numeric` attribute set to `True`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_is_numeric is an internal attribute, I do not think we should be mentioning it in the docs. It seems to me this sentence can be removed without loss of clarity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rhshadrach , resolved in 494aaad

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chilin0525 LGTM

@mroeschke mroeschke requested a review from rhshadrach July 21, 2025 16:43
@mroeschke mroeschke added this to the 3.0 milestone Jul 21, 2025
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit bd9f060 into pandas-dev:main Jul 21, 2025
43 checks passed
@rhshadrach
Copy link
Member

Thanks @chilin0525!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Clarify to_numeric behavior for numeric dtypes
4 participants