DOC: Clarify to_numeric behavior for numeric dtypes #61904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chilin0525
changed the title
5 tasks
rhshadrach
requested changes
Jul 19, 2025
pandas/core/tools/numeric.py
Outdated
Comment on lines
61
to
62
| to obtain other dtypes. Numeric dtypes include all dtypes that have | ||
| the `_is_numeric` attribute set to `True`. |
There was a problem hiding this comment.
_is_numeric is an internal attribute, I do not think we should be mentioning it in the docs. It seems to me this sentence can be removed without loss of clarity.
There was a problem hiding this comment.
Thanks @rhshadrach , resolved in 494aaad
simonjayhawkins
approved these changes
Jul 21, 2025
|
Thanks @chilin0525! |
eicchen
pushed a commit
to eicchen/pandas
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.