BUG: to_numeric fails to convert a Pyarrow Decimal series containing NA values #62975
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisznie
changed the title
Alvaro-Kothe
reviewed
Nov 5, 2025
| def test_to_numeric_arrow_decimal_with_na(dtype): | ||
| # GH 61641 | ||
| pa = pytest.importorskip("pyarrow") | ||
| target_class = globals()[dtype] |
There was a problem hiding this comment.
This is very confusing. Can you parametrize with the class directly?
| "ArrowDtype", | ||
| ], | ||
| ) | ||
| def test_to_numeric_arrow_decimal_with_na(dtype): |
There was a problem hiding this comment.
In a comment in the original PR, there was a request to parametrize different dtypes that should be a no-op.
On the top of my head, I think it's possible to test Int64Dtype and Float64Dtype, although, I think it will require to create another test for non-pyarrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on the work done in #61659
to_numericfails to convert a Pyarrow Decimal series containing NA values. #61641doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.