ENH: adding autofilter when writing to excel (pandas-dev#61194) #62994
Conversation
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
Small comment but overall looks like a really nice PR. @rhshadrach any thoughts?
| Convert 0-based column index to Excel column name. | ||
| """ | ||
| column_name = "" | ||
| while index > 0 or not column_name: |
There was a problem hiding this comment.
Can you raise when index < 0? Also, what's the point of this being a while loop?
There was a problem hiding this comment.
Ignore my while loop comment - I supposed its so you can build column references like AA, BA, etc...
So makes sense, but still in need of a cleanup here
There was a problem hiding this comment.
@WillAyd Thanks for the feedback - input validation added.
pandas/tests/io/excel/test_style.py
Outdated
| ws = wb.active | ||
|
|
||
| assert ws.auto_filter.ref is not None | ||
| print(ws.auto_filter.ref) |
There was a problem hiding this comment.
Can you remove the print statement?
There was a problem hiding this comment.
Print statement removed - thanks for checking!
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
lgtm - let's see what others think
| startrow: int = 0, | ||
| startcol: int = 0, | ||
| freeze_panes: tuple[int, int] | None = None, | ||
| autofilter_range: str | None = None, |
There was a problem hiding this comment.
It seems to me we should be raising an error here if a user specifies autofilter=True and it is not supported with an engine rather than silently ignore the user's specification.
3 participants
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.Description of the change:
Added boolean 'autofilter' optional argument to 'DataFrame.to_excel' function to add automatic filters to all columns in the exported excel files. As discussed with @WillAyd starting simple by allowing to add filters only to all or none columns.
New option supported by 'xlsxwriter' and 'openpyxl' engines.