BUG: Stop item_from_zerodim from converting subclasses of np.ndarray to float
#62999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue with objects of a subclass of
np.ndarrayto be converted tofloatinitem_from_zerodimitem_from_zerodimconverts objects of subclasses ofndarraytofloat#62981doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Not sure if there should be a test to cover this case. Could be created with a
TestArrayclass as shown in #62981. Also should the docstring of the function be modified to reflect that now only objects ofnp.ndarrayare converted? Current description is a bit ambigues: