BUG: fix date_range inclusive filtering with periods#64788
Merged
mroeschke merged 1 commit intopandas-dev:mainfrom Mar 25, 2026
Merged
BUG: fix date_range inclusive filtering with periods#64788mroeschke merged 1 commit intopandas-dev:mainfrom
mroeschke merged 1 commit intopandas-dev:mainfrom
Conversation
jbrockmendel
force-pushed
the
bug-46331
branch
3 times, most recently
from
17919cf to
b9b57db
Compare
When date_range was called with start+periods or end+periods (without the other endpoint), the inclusive parameter failed to filter the unspecified endpoint because Timestamp(None) produced NaT, causing the endpoint comparison to always fail. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mroeschke
approved these changes
Mar 25, 2026
Member
|
Thanks @jbrockmendel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
date_rangeignoring theinclusiveparameter when called withstart+periodsorend+periods(without the other endpoint)end(orstart) wasNone,Timestamp(None)producedNaT, so the endpoint comparison always failed and the boundary value was never filtered outstart/endisNonecloses #46331
Test plan
start+periodsandend+periodsacross all fourinclusivevalues (both,left,right,neither)date_rangetests continue to pass🤖 Generated with Claude Code