-
Notifications
You must be signed in to change notification settings - Fork 44
Fix multi view model prediction #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi view model prediction #328
Conversation
|
Ahh, the test for |
|
Hi @Dominic-DallOsto thanks for the bug find/fix! I just returned from traveling so I'll take a closer look at this later this afternoon |
|
Thanks for the feature! I liked the proposal and just made a few minor tweaks as I reviewed. (My first time reviewing a PR by following up with a PR - I thought this might be the easiest way to minimize the work for you to accept the changes) Do you mind adding test cases for the new split function? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks! I added some tests. Let mw know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested this with my multi view model and it works with the nice pretty printing now
Fixes #327
I changed the
find_videos_files_for_viewsfunction to return a list of lists of videos like[[session0_view0.mp4, session0_view1.mp4, ...], [session1_view0.mp4, session1_view1.mp4, ...], ...].This then lets us loop over all sessions in the training videos directory and feed the videos from all the different views to the model.
Additionally, I modified
litpose predictfor multi view models to accept a list of videos from multiple views, or a list of directories that each contain videos from multiple views. If there's a different way of handling this that you prefer that's no problem!