Skip to content

Conversation

Dominic-DallOsto
Copy link
Contributor

@Dominic-DallOsto Dominic-DallOsto commented Oct 17, 2025

Fixes #327

I changed the find_videos_files_for_views function to return a list of lists of videos like [[session0_view0.mp4, session0_view1.mp4, ...], [session1_view0.mp4, session1_view1.mp4, ...], ...].

This then lets us loop over all sessions in the training videos directory and feed the videos from all the different views to the model.

Additionally, I modified litpose predict for multi view models to accept a list of videos from multiple views, or a list of directories that each contain videos from multiple views. If there's a different way of handling this that you prefer that's no problem!

@Dominic-DallOsto Dominic-DallOsto changed the title Dominic-DallOsto/issue327 Fix multi view model prediction Oct 17, 2025
@Dominic-DallOsto
Copy link
Contributor Author

Ahh, the test for find_video_files_for_views is failing because I changed its behaviour. Happy to update it if you think the new behaviour makes sense.

@themattinthehatt
Copy link
Collaborator

Hi @Dominic-DallOsto thanks for the bug find/fix! I just returned from traveling so I'll take a closer look at this later this afternoon
@LennyAharon

@ksikka
Copy link
Collaborator

ksikka commented Oct 20, 2025

Thanks for the feature! I liked the proposal and just made a few minor tweaks as I reviewed.
Dominic-DallOsto#1

(My first time reviewing a PR by following up with a PR - I thought this might be the easiest way to minimize the work for you to accept the changes)

Do you mind adding test cases for the new split function?

Copy link
Contributor Author

@Dominic-DallOsto Dominic-DallOsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! I added some tests. Let mw know what you think

Copy link
Contributor Author

@Dominic-DallOsto Dominic-DallOsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested this with my multi view model and it works with the nice pretty printing now

@ksikka ksikka merged commit e31dc2a into paninski-lab:main Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi view transformer doesn't run prediction properly

3 participants