[SITE-5390] Adds compatibility fixes for PHP 8.4.8#336
Draft
AnaisPantheor wants to merge 2 commits intomainfrom
Draft
[SITE-5390] Adds compatibility fixes for PHP 8.4.8#336AnaisPantheor wants to merge 2 commits intomainfrom
AnaisPantheor wants to merge 2 commits intomainfrom
Conversation
Comment on lines
-80
to
+82
| if ( isset( $_GET['message'] ) && in_array( $_GET['message'], [ 'delete-all-session', 'delete-session' ], true ) ) { | ||
| if ( 'delete-all-session' === $_GET['message'] ) { | ||
| // Check for success message transient. | ||
| $transient_key = 'pantheon_sessions_message_' . get_current_user_id(); | ||
| $session_message = get_transient( $transient_key ); |
Contributor
There was a problem hiding this comment.
I still don't understand this pattern and I don't think it's a good practice. We can just add nonce checks to the $_GET checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated drafts from Claude Code - will stay in draft until I actually look at them
PHP 8.4 Compatibility fixes suggested by Claude Code
pantheon-sessions.php
- Fixed 3 critical logic bugs (lines 552, 656, 709)
- Changed 3 loose comparisons to strict comparisons (lines 335, 542, 629)
inc/class-admin.php
- Updated to use transients instead of URL parameters for messages