[SITE-5390] Add fixes for PHP 8.4.8 compatibility#525
Draft
AnaisPantheor wants to merge 1 commit intomainfrom
Draft
[SITE-5390] Add fixes for PHP 8.4.8 compatibility#525AnaisPantheor wants to merge 1 commit intomainfrom
AnaisPantheor wants to merge 1 commit intomainfrom
Conversation
jazzsequence
requested changes
Jan 23, 2026
Contributor
jazzsequence
left a comment
jazzsequence
left a comment
There was a problem hiding this comment.
There are a bunch of wporg validation fixes that should be made and also a couple comment changes that would break our own linting rules in 3.0 (not sure what version we're using on this project). Overall, it looks fine once it's cleaned up.
Comment on lines
+1359
to
+1360
| // PhpRedis throws an Exception when it fails a server call. | ||
| // To prevent WordPress from fataling, we catch the Exception. |
Contributor
There was a problem hiding this comment.
This comment change will break Pantheon WP Coding Standards in 3.0
Comment on lines
+1395
to
+1396
| // PhpRedis throws an Exception when it fails a server call. | ||
| // To prevent WordPress from fataling, we catch the Exception. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated drafts from Claude Code - will stay in draft until I actually look at them
PHP 8.4.8 Fixes suggested by ClaudeCode
Added proper property declarations in /wp-content/plugins/wp-redis/object-cache.php at line 442-461:
The WP_Object_Cache class was using three properties without declaring them:
$redis - The Redis client instance
$missing_redis_message - Error message string
$global_prefix - Global cache key prefix
The change from $port = -1; to $port = null; is a PHP 8.4 compatibility fix.
PHP 8.4 stricter type handling: PHP 8.4 has stricter type checking, and passing -1 as a port value may trigger deprecation warnings or errors