Skip to content

Conversation

niol
Copy link

@niol niol commented Aug 28, 2025

No description provided.

@Thesola10 Thesola10 changed the base branch from release to develop August 28, 2025 08:50
@niol niol marked this pull request as ready for review August 29, 2025 06:48
@niol niol marked this pull request as draft September 2, 2025 05:46
@niol niol marked this pull request as ready for review September 2, 2025 08:44
Copy link
Collaborator

@SanTeeg0 SanTeeg0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
I think it would be better to keep the default behavior of make install(install the extension locally for user), as it's what will be used most often anyway. This will also ensure some backward compatibility.
Other than that, everything looks good to me.

@niol
Copy link
Author

niol commented Sep 5, 2025

I understand. What do you want as target name for system-wide install?
Please note make install is the standard way of installing software on Unixes system-wide.

@SanTeeg0
Copy link
Collaborator

SanTeeg0 commented Sep 5, 2025

Please note make install is the standard way of installing software on Unixes system-wide.

That's true, but mainly for packages, tools, etc. Extensions, themes, and so on are mostly user-specific. Also, PaperWM only had one way for users to install it locally, which was with make install, so changing this behavior could cause more confusion.

I understand. What do you want as target name for system-wide install?

Something like make install-system could be sufficient.

Copy link
Collaborator

@SanTeeg0 SanTeeg0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
But currently, the only option is to install the extension in the system using make install-system, but I think it would be great if there was a way to uninstall it. Especially using the same make uninstall command (to remove both the local and system versions, if any).

Sorry for my oversight, I could have noticed this earlier.

@niol
Copy link
Author

niol commented Sep 8, 2025

Looks great! But currently, the only option is to install the extension in the system using make install-system, but I think it would be great if there was a way to uninstall it. Especially using the same make uninstall command (to remove both the local and system versions, if any).

Then I'll need $prefix so that I'll try to work out something.

@niol
Copy link
Author

niol commented Sep 9, 2025

The uninstall target is currently broken due to /bin/sh syntax errors when run on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants