Add arm64 platform build #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support arm64 builds, added the --platform tag to the build command so that arm64 builds are generated in addition to amd64 builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in Issue #69, it would be nice if there were arm64 builds in addition to the amd64 ones so that craneoperator could be run in the Raspberry Pi. Therefore this PR adds the
--platformflag to the docker build as defined by v1.4 of the docker API and utilizes buildx as described here to allow both arm64 and amd64 builds to be generated at the same time.If I've gotten something wrong here just let me know or feel free to ignore this PR (as I don't have access to CircleCI I can't exactly test this).