Skip to content

fix: deduplicate TxpoolExt RPC methods #19367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: deduplicate TxpoolExt RPC methods #19367

wants to merge 1 commit into from

Conversation

@vtjl10
Copy link
Contributor

@vtjl10 vtjl10 commented Oct 28, 2025

Deduplicate RPC method logic in examples/node-custom-rpc/src/main.rs by extracting shared behavior into private helpers. Added transaction_count_inner() and clear_txpool_inner() on TxpoolExt and updated both TxpoolExtApiServer impls (prod and test) to call the shared helpers.

@vtjl10 vtjl10 requested a review from gakonst as a code owner October 28, 2025 20:30
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 28, 2025
mattsse
mattsse reviewed Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can keep this as is

@mattsse mattsse closed this Nov 3, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse left review comments

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtjl10 @mattsse