feat(engine/metrics): add latest valid fcu#20628
feat(engine/metrics): add latest valid fcu#20628figtracer wants to merge 3 commits intoparadigmxyz:mainfrom
Conversation
Rjected
left a comment
There was a problem hiding this comment.
Should have specified this better in the issue, but I don't think it's useful to have the hash bits as a gauge. We should instead have a number for the latest valid fcu head / safe / finalized
on it |
|
this will run if fcu is invalid as well, but ig it's not that relevant |
mattsse
left a comment
There was a problem hiding this comment.
not perfectly clear to me what the use case for this is
We should track these in metrics, so that we can see what the latest valid state is without logs
the last valid tags would track:
reth/crates/chain-state/src/chain_info.rs
Lines 154 to 161 in dea27a5
so perhaps we add the metrics there instead?
| if let Some(last_valid) = | ||
| self.state.forkchoice_state_tracker.last_valid_state() | ||
| { | ||
| let block_num = |hash| { |
There was a problem hiding this comment.
his now most likely always goes to disk for the finalized/safe block, before we send the respond
we need to avoid this
we already track the finalized/safe/head block, unsure what the use case for these metrics are here
is this just for tracking what we receive as fcu or what we actually have as finalized/safe/head @Rjected ?
because we already have:
reth/crates/chain-state/src/chain_info.rs
Lines 100 to 131 in dea27a5
#20621