perf(engine): parellelize multiproof_targets_from_state #20669
Merged
+47
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
figtracer
requested review from
Rjected,
fgimenez,
mattsse,
mediocregopher and
yongkangc
as code owners
mattsse
requested changes
Jan 6, 2026
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
makes sense, smol suggestions
| .collect(); | ||
|
|
||
| let mut targets = MultiProofTargets::default(); | ||
| let mut storage_targets = 0usize; |
Collaborator
There was a problem hiding this comment.
isn't this equivalent to smth like MultiProofTargets::storage_targets_count?
Contributor
Author
There was a problem hiding this comment.
i think we don't have that available but we can add it
| // do nothing if unchanged | ||
| if !slot.is_changed() { | ||
| continue | ||
| let results: Vec<_> = state |
Collaborator
There was a problem hiding this comment.
I think we could collect this directly into B256Map? then we don't need to collect into vec then insert into map?
|
|
||
| /// Returns a set of [`MultiProofTargets`] and the total amount of storage targets, based on the | ||
| /// given state. | ||
| fn multiproof_targets_from_state(state: EvmState) -> (MultiProofTargets, usize) { |
Collaborator
There was a problem hiding this comment.
I think we can change this to just return MultiProofTargets and then add a helper fn for counting the targets?
mattsse
added
the
C-perf
mattsse
requested changes
Jan 6, 2026
Comment on lines
+32
to
+39
| impl FromParallelIterator<(B256, B256Set)> for MultiProofTargets { | ||
| fn from_par_iter<I>(par_iter: I) -> Self | ||
| where | ||
| I: IntoParallelIterator<Item = (B256, B256Set)>, | ||
| { | ||
| Self(par_iter.into_par_iter().collect()) | ||
| } | ||
| } |
Comment on lines
-772
to
-778
| // if the account was not touched, or if the account was selfdestructed, do not | ||
| // fetch proofs for it | ||
| // | ||
| // Since selfdestruct can only happen in the same transaction, we can skip | ||
| // prefetching proofs for selfdestructed accounts | ||
| // | ||
| // See: https://eips.ethereum.org/EIPS/eip-6780 |
mattsse
approved these changes
Jan 6, 2026
mattsse
added a commit
that referenced
this pull request
Jan 7, 2026
…)" This reverts commit 6384226.
meetrick
pushed a commit
to meetrick/reth
that referenced
this pull request
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same reasoning as this #20635