Skip to content

fix(config): call validate() when loading static file config #20683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ethfanWilliam wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(config): call validate() when loading static file config #20683

ethfanWilliam wants to merge 2 commits into from

Conversation

@ethfanWilliam
Copy link
Contributor

@ethfanWilliam ethfanWilliam commented Dec 30, 2025

validate() was already implemented but never called in from_path(), so invalid blocks_per_file values (like 0) would only blow up at runtime.

now we validate right after parsing.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ethfanWilliam