fix: history index stages incorrectly detect first sync with non-zero… #20715
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Jan 5, 2026
Comment on lines
+102
to
+103
| let first_sync = | ||
| provider.tx_ref().cursor_read::<tables::AccountsHistory>()?.last()?.is_none(); |
Collaborator
There was a problem hiding this comment.
we shouldnt use raw cursors here because this will complicate things with static files I think.
also I dont think there's a valid reason for this, even if the node is initialized with block > 0 dont think we insert history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The history index stages were hardcoding block 0 to check for first sync, which fails when genesis starts at a non-zero block. This prevented the first-sync optimization (clearing tables and rebuilding from scratch) from running.
Changed to check if the history table is empty instead, and use the actual checkpoint block number as the starting point rather than assuming 0.