-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(engine): do not create another cache for multiproof task #20755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+28
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62e57ff to
c292119
Compare
c292119 to
86f6e8a
Compare
a37ab47 to
d58179c
Compare
a3f5aba to
c7a5203
Compare
… task" This reverts commit 27eec41.
DaniPopes
approved these changes
Jan 6, 2026
mattsse
requested changes
Jan 6, 2026
mattsse
approved these changes
Jan 6, 2026
meetrick
pushed a commit
to meetrick/reth
that referenced
this pull request
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Every time
cache_foris called, we check that it's going to be the only cache in use:reth/crates/engine/tree/src/tree/payload_processor/mod.rs
Lines 786 to 788 in 790a73c
First
cache_forcall is happening herereth/crates/engine/tree/src/tree/payload_processor/mod.rs
Line 252 in fa05d19
Second is here
reth/crates/engine/tree/src/tree/payload_processor/mod.rs
Line 297 in fa05d19
Which leads to always creating a new cache on the second call
Solution
Get cache once with
cache_forand pass to all consumers.