Conversation
Contributor
|
Collaborator
|
This is main PR for the code that we re-executed and resynced on sepolia |
mattsse
previously approved these changes
Apr 14, 2026
klkvr
reviewed
Apr 14, 2026
| { | ||
| self.transactions.push(tx); | ||
| Ok(Some(gas_used)) | ||
| Ok(Some(gas_used.tx_gas_used())) |
Member
There was a problem hiding this comment.
is this right? i believe the only actual consumer of this output is here
reth/crates/ethereum/payload/src/lib.rs
Line 338 in a9bd38a
and we might need to change it given Amsterdam changes how block gas limit is calculated?
klkvr
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps revm to
8891655bb, alloy-evm toec772db, revm-inspectors toecc5bc7, and reth tob25459035f.Adapts reth to the EIP-8037
GasTrackerchanges:gas_used/gas.used()→gas.tx_gas_used()/gas.limit() - gas.remaining()PrecompileOutputnow usesGasTrackerinstead of separategas_used/gas_refundedfieldsinitial_gas→initial_total_gasin intrinsic gas validationEVMError::CustomAnyvariantcommit_transactionreturnsGasOutputinstead ofu64opfeature flags for crates not yet compatible