test: signal background metrics hook completion - #27047
Merged
Merged
Conversation
Replace the fixed two-second hook delay with an explicit release channel and completion notification. Preserve the HTTP scrape and collection assertions, with cleanup on assertion failure. Baseline CI duration was 2.047 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold the first background metrics hook until its scrape returns, then release it explicitly and await notification after publishing the gauge. Preserve the nonblocking-scrape, metric-output, and collection-count assertions; dropping the sender unblocks the hook on assertion failure, and later invocations remain observable.
The test fell from 2.047s on main (2.050s in the contemporary control) to 0.042s in CI, removing the two-second sleep and polling loop. All 3,251 unit tests passed without retries. Authored with Codex.