feat(download): allow retry delay overrides - #27048
Merged
Merged
Conversation
Preserve default retry schedules while allowing a fixed delay for custom endpoints. The checksum failure test uses zero delay and explicitly checks ten fresh downloads before failed finalization. It runs in 3.685s locally; the CI baseline is 48.147s, including 45s of backoff.
mattsse
added
C-test
mattsse
marked this pull request as ready for review
September 6, 2026 20:51
mattsse
enabled auto-merge
September 7, 2026 10:52
emmajam
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
reth download --retry-backoff <DURATION>to override retry delays while preserving the existing defaults and attempt counts. The checksum-failure test uses zero delay and now explicitly checks ten fresh archive downloads and exhausted integrity validation, alongside the failed exit status and absent final database/configuration.The test fell from 48.147s to 3.181s in CI, about 93% faster; locally, the same assertions took 48.633s without the option and 3.685s / 3.634s with zero delay. The checksum mismatch is intentional, and no integrity check is bypassed. All 580 integration tests passed, with two unrelated tests retrying. Authored with Codex.