fix(download): reject zero blocks_per_file in snapshot manifest - #27049
Open
Aditya-9-6 wants to merge 1 commit into
Open
fix(download): reject zero blocks_per_file in snapshot manifest#27049Aditya-9-6 wants to merge 1 commit into
Aditya-9-6 wants to merge 1 commit into
Conversation
Reject zero blocks_per_file before expanding snapshot archives or computing chunk counts. Fixes paradigmxyz#27030.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #27030
A modular snapshot manifest with
blocks_per_file: 0triggers a divide-by-zero panic inChunkedArchive::num_chunks()(self.total_blocks.div_ceil(self.blocks_per_file)) when calculating chunk counts and expanding snapshot archives.This PR addresses this by:
SnapshotManifest::validate(&self)to check that any chunked component specifiesblocks_per_file > 0.manifest.validate()?early inDownloadCommand::load_manifest()right after verifyingchain_id.collect_planned_archives()before chunk consistency verification.ChunkedArchive::num_chunks()andChunkedArchive::tail_chunks_for_distance(), plus saturating arithmetic inChunkedArchive::chunk_relative_path().ChunkedArchivebehavior.