feat: scalffold new snap-sync crate with minimal pivot module - #27054
Open
lean-apple wants to merge 4 commits into
Open
feat: scalffold new snap-sync crate with minimal pivot module#27054lean-apple wants to merge 4 commits into
snap-sync crate with minimal pivot module#27054lean-apple wants to merge 4 commits into
Conversation
lean-apple
force-pushed
the
feat/snap-sync-crate
branch
from
September 7, 2026 08:23
102438a to
298efbe
Compare
lean-apple
marked this pull request as ready for review
September 7, 2026 19:39
Selection stopped at the finalized block, so a finalized block predating EIP-7928 activation reported no pivot at all even when the head distance anchor was eligible. Try that fallback before waiting.
lean-apple
force-pushed
the
feat/snap-sync-crate
branch
from
September 7, 2026 19:43
851f856 to
3f6e68e
Compare
A snap attempt now has a lifecycle: it waits explicitly while no block is eligible, replaces or drops a target no work has taken yet as the chain moves, hands a started target to a single owner, and cancels outstanding work. Advancing a target that is already downloading, and the downloads themselves, stay out of scope here.
lean-apple
force-pushed
the
feat/snap-sync-crate
branch
from
September 7, 2026 19:50
3f6e68e to
dbb98e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to OSS-744.
Adds
reth-snap-syncwith pivot selection and a session that identifies each attempt by its pivot hash and state root. Prefers a recent finalized block, falling back to 64 blocks behind the head when needed.The session waits when no eligible pivot is available, replaces or clears an unstarted target as the chain changes, and signals cancellation to outstanding work.