fix(interface): honor no_warnings in DiagCtxtFlags::update_from_opts#744
Open
cuiweixie wants to merge 1 commit intoparadigmxyz:mainfrom
Open
fix(interface): honor no_warnings in DiagCtxtFlags::update_from_opts#744cuiweixie wants to merge 1 commit intoparadigmxyz:mainfrom
cuiweixie wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
Use bitwise AND so disabling warnings clears can_emit_warnings. The previous OR-assignment left the flag true whenever it started true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiagCtxtFlags::update_from_optsused|= !opts.no_warnings, which never clearedcan_emit_warningswhen it was alreadytrue(the default). Replace with&= !opts.no_warningssono_warningsactually suppresses warnings.Notes
Small logic fix in diagnostic flags; aligns behavior with
Opts::no_warnings.