Repository navigation
Enabled psa_mac_compute and psa_mac_verify functions. - #143
Merged
Merged
Conversation
Added new tests, fixed doc tests and formatted code. Signed-off-by: Mike Smoot <mes@aescon.com>
Signed-off-by: Mike Smoot <mes@aescon.com>
Signed-off-by: Mike Smoot <mes@aescon.com>
Signed-off-by: Mike Smoot <mes@aescon.com>
Signed-off-by: Mike Smoot <mes@aescon.com>
Member
|
Sorry for having left this on the side! If you would like to rebase to re-trigger CI I would be happy to merge 🙏 |
Signed-off-by: Mike Smoot <mes@aescon.com>
Contributor
Author
|
Thanks @hug-dev, just pushed the updates. |
hug-dev
previously approved these changes
Jan 19, 2026
hug-dev
left a comment
hug-dev
left a comment
Member
There was a problem hiding this comment.
Thanks for this! Nice formatting and tests too 👍
Signed-off-by: Mike Smoot <mes@aescon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the
psa_mac_computeandpsa_mac_verifyfunctions. I added new tests, fixed doc tests and formatted the code.Everything seems to work fine, at least to my inexperienced eye. Please review closely and let me know if anything additional is needed.
My only real conceptual question is whether I should be checking if the size > 0 after the called to
psa_crypto_sys::PSA_MAC_LENGTHin themac_lengthfunction. This makes sense to me as a belt and suspenders approach to ensuring we don't end up with a 0 size mac buffer. On the other hand, I haven't been able to come up with a test scenario where this might happen, so maybe it's not necessary?Thanks!