-
Notifications
You must be signed in to change notification settings - Fork 64
Adds building and testing of examples to CI. #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
65e4dbe to
f0335b4
Compare
tss-esapi/tests/examples.sh
Outdated
| ################## | ||
| # Build examples # | ||
| ################## | ||
| RUST_BACKTRACE=1 cargo build --examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this shouldn't be necessary as cargo test --examples needs to build them first anyway... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but its nice to separate build errors from running the examples errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but its nice to separate build errors from running the examples errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I suggest using cargo check which shows build errors but doesn't waste time creating output artifacts (that we wouldn't need in CI anyway). 👋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that could be done.
Oh I just noted that the script does not start the tpm server ... But everything is green anyway ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that could be done.
Oh I just noted that the script does not start the tom server ... But everything is green anyway ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was way more complicated then I expected. The examples requires a resource broker.
5cfecc7 to
e1fd179
Compare
e1fd179 to
85e36c0
Compare
Signed-off-by: Jesper Brynolf <[email protected]>
85e36c0 to
2807879
Compare
Fixes #467