pallet-revive: allow changing immutables #9801
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
requested review from
pgherveou,
athei,
smiasojed,
pkhry and
filip-parity
and removed request for
pgherveou
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
athei
approved these changes
Sep 25, 2025
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
added
T2-pallets
pgherveou
reviewed
Sep 25, 2025
Comment on lines
+1696
to
+1698
| /// # Warning | ||
| /// | ||
| /// Does not collect any storage deposit. Not safe to be called by user controlled code. |
There was a problem hiding this comment.
maybe we should reflect that in the method's name too
There was a problem hiding this comment.
Do you have any suggestion on how you want me to prefix/suffix it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to be used in polkadot foundry to make sure EVM state is in sync with pallet-revive state.
Fixes: paritytech/foundry-polkadot#277