- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.8k
          feat: Allow returning objects in Parse.Cloud.beforeFind without invoking database query
          #9770
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
      
        
          +524
        
        
          −41
        
        
          
        
      
    
  
  
     Merged
                    Changes from 31 commits
      Commits
    
    
            Show all changes
          
          
            55 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      6f65ec5
              
                feat: allow short circuit of beforeFind
              
              
                dblythy 41bf1b7
              
                improve test description
              
              
                mtrezza 21c9289
              
                Update CloudCode.spec.js
              
              
                dblythy ca74929
              
                wip
              
              
                dblythy 207c3c0
              
                wip
              
              
                dblythy bc68816
              
                wip
              
              
                dblythy d66fa48
              
                Merge branch 'alpha' into beforeFind-objects
              
              
                mtrezza 34f7741
              
                feat: allow short circuit of beforeFind
              
              
                dblythy 5825abf
              
                improve test description
              
              
                mtrezza 6daa039
              
                Update CloudCode.spec.js
              
              
                dblythy ec37789
              
                wip
              
              
                dblythy 09fcde2
              
                wip
              
              
                dblythy 8de0edb
              
                Merge branch 'beforeFind-objects' of https://github.com/dblythy/parse…
              
              
                EmpiDev dd75062
              
                refactor: remove redundant beforeFind tests and clean up afterFind hooks
              
              
                EmpiDev 8d6aae6
              
                refactor: improve condition checks and format function parameters for…
              
              
                EmpiDev c5dd665
              
                test: update beforeFind test to create and save a new object
              
              
                EmpiDev 55c3b3b
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                EmpiDev d8525e9
              
                fix : Unexpected token '}' 2057
              
              
                EmpiDev 04ae88f
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                EmpiDev f083527
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                EmpiDev f679ba0
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                EmpiDev dfd4082
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                EmpiDev 43a87bb
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                mtrezza c417118
              
                refactor: Improve afterFind trigger handling and object processing
              
              
                EmpiDev c6463c3
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                EmpiDev 0c2ad57
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                mtrezza 92ef147
              
                refactor in CloudCode.spec.js
              
              
                EmpiDev 546e5b0
              
                refactor in triggers.js
              
              
                EmpiDev 00b104e
              
                test: Add direct function tests for maybeRunAfterFindTrigger
              
              
                EmpiDev 2a5dce9
              
                Remove unnecessary comment
              
              
                EmpiDev 98be232
              
                refactor: Replace isGet boolean flag with options object
              
              
                EmpiDev 0d42676
              
                 Provide isGet context to afterFind trigger
              
              
                EmpiDev f197119
              
                fix: Correct parameter formatting in afterFind trigger test
              
              
                EmpiDev 06e2bcc
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                EmpiDev 52d5594
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                mtrezza c08b3f6
              
                chore(tests): add spy to confirm DB is not accessed
              
              
                EmpiDev 37f74c1
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                mtrezza 468a6ec
              
                refactor(tests): extract database spy setup into a helper function fo…
              
              
                EmpiDev b157aa2
              
                refactor(tests): move repetitive code into beforeEach block
              
              
                EmpiDev 83a918b
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                mtrezza 840a3e4
              
                feat: Add beforeFind security tests for object visibility and protect…
              
              
                EmpiDev 3da7ffb
              
                feat: Enhance beforeFind security tests for object visibility and acc…
              
              
                EmpiDev 041b00d
              
                feat:  Re-apply ACL/CLP systematically when beforeFind returns objects
              
              
                EmpiDev bf70c6a
              
                feat: Add explicit comments in runFindTriggers, triggers.js
              
              
                EmpiDev 6ec28a8
              
                tests: normalize query construction to production conditions; avoid a…
              
              
                EmpiDev c49f8aa
              
                refactor: simplify query handling in maybeRunAfterFindTrigger
              
              
                EmpiDev 0d68f26
              
                refactor: streamline id handling and security checks in runFindTriggers
              
              
                EmpiDev f5acfa0
              
                Revert "refactor: streamline id handling and security checks in runFi…
              
              
                EmpiDev ec9033d
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                EmpiDev 97e143a
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                mtrezza fdd9270
              
                Add code comment in runFindTriggers
              
              
                EmpiDev 08865e3
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                mtrezza 069551f
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                mtrezza caa5037
              
                fix: remove unnecessary blank lines
              
              
                EmpiDev 852f29f
              
                Merge branch 'alpha' into beforeFind-fix
              
              
                EmpiDev File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
          Some comments aren't visible on the classic Files Changed page.
        
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.