Skip to content

Added non-existed open graph and twitter properties#286

Open
ugurhangul wants to merge 11 commits intopatrickdemooij9:dev/Umbraco11from
ugurhangul:dev/Umbraco11
Open

Added non-existed open graph and twitter properties#286
ugurhangul wants to merge 11 commits intopatrickdemooij9:dev/Umbraco11from
ugurhangul:dev/Umbraco11

Conversation

@ugurhangul
Copy link
Copy Markdown

Added non-existed open graph and twitter properties along with new open graph and twitter groups,
Added default option for dropdown property,
Added SeoVideoEditEditor media picker property,
Solved MetaFieldsTagHelper.cs null exception bug when MediaPicker property null,
Facebook App Id title changed.

@ugurhangul
Copy link
Copy Markdown
Author

Known bug;

Image and Video editor fallback values sets as class name

@dederuhi
Copy link
Copy Markdown

great enhancement

@patrickdemooij9
Copy link
Copy Markdown
Owner

Hi @ugurhangul

Thank you for this huge Pull request! It looks very good! I did also spot the same issue as you with the Image and Video editor fallback values sets as class name. And now that we have sections for all the different social websites, the previewers probably should just use the corresponding one (so twitter section = twitter previewer) instead of all.

But other than that, this looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants