Skip to content

Invoke methods of a generic class or of a class with generic base class #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
objmalloc wants to merge 1 commit into
base: master
Choose a base branch
from
+39 −1
Open

Invoke methods of a generic class or of a class with generic base class #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion Jurassic/Compiler/Binders/BinderUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,48 @@ public static class BinderUtilities
/// <returns> The index of the selected method. </returns>
public static int ResolveOverloads(RuntimeMethodHandle[] methodHandles, ScriptEngine engine, object thisValue, object[] arguments)
{
object thisUnwrapped = thisValue;
if (thisUnwrapped is Library.ClrInstanceWrapper)
{
thisUnwrapped = (thisUnwrapped as Library.ClrInstanceWrapper).WrappedInstance;
}
Type unwrappedType;
if (thisUnwrapped is Library.ClrStaticTypeWrapper)
{
unwrappedType = (thisUnwrapped as Library.ClrStaticTypeWrapper).WrappedType;
}
else if (thisUnwrapped is Library.ClrInstanceTypeWrapper)
{
unwrappedType = (thisUnwrapped as Library.ClrInstanceTypeWrapper).WrappedType;
}
else
{
unwrappedType = thisUnwrapped.GetType();
}

// Get methods from the handles.
var methods = new BinderMethod[methodHandles.Length];
for (int i = 0; i < methodHandles.Length; i++)
methods[i] = new BinderMethod(MethodBase.GetMethodFromHandle(methodHandles[i]));
{
if (unwrappedType.IsGenericType)
{
// Generic methods. Works for classes which are generic.
methods[i] = new BinderMethod(
MethodBase.GetMethodFromHandle(methodHandles[i], unwrappedType.TypeHandle));
}
else if (unwrappedType.BaseType != null && unwrappedType.BaseType.IsGenericType)
{
// Generic methods. Works for classes which inherit generic type.
// For example: class AlternateViewCollection : Collection<AlternateView>
methods[i] = new BinderMethod(
MethodBase.GetMethodFromHandle(methodHandles[i],
unwrappedType.BaseType.TypeHandle));
}
else
{
methods[i] = new BinderMethod(MethodBase.GetMethodFromHandle(methodHandles[i]));
}
}

// Keep a score for each method. Add one point if a type conversion is required, or
// a million points if a type conversion cannot be performed.
Expand Down