feat: replace alert() with toast notifications#150
Open
EricGrill wants to merge 1 commit intopbogre:mainfrom
Open
feat: replace alert() with toast notifications#150EricGrill wants to merge 1 commit intopbogre:mainfrom
EricGrill wants to merge 1 commit intopbogre:mainfrom
Conversation
Replace intrusive JavaScript alert() calls with non-blocking toast notifications that appear in the bottom-right corner and auto-dismiss after 5 seconds. Changes: - Add Toast component with ToastProvider context - Replace error alerts in api.ts with error toasts - Replace success alerts in Settings.tsx with success toasts - Replace error alerts in FetchConnection.tsx with error toasts - Add slide-in animation for toast appearance Fixes pbogre#3 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
|
Hey, thanks a lot for submitting these PRs! I will take a look as soon as I can, but be aware that I have final exams coming in the next couple weeks so I unfortunately wont have time to do this until after I finished them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alert()calls with toast notificationsChanges
Toast.tsxcomponent with React Context for state managementshowToast()function for non-component code (api.ts)ToastProvidercomponentCloses #3
Test plan
🤖 Generated with Claude Code