Reduce FFO fatigue and simplify commissioning state positioners through single boolean ffo off using maintenance mode#250
Draft
NSLentz wants to merge 2 commits intopcdshub:masterfrom
Draft
Conversation
…ction block is not enabled such as when we are in maintenance mode.
…ioner to make maintenance mode a one stop shop to stop all ffos and arbitration from occuring for a given state positioner.
Member
|
I agree with the general approach here- I might have a related thought about reducing the number of FFOs in general. But this is a good idea. |
ZLLentz
reviewed
Feb 26, 2026
| // Trip the beam for BPTM timeouts if we want to move | ||
| // Only reset at safe beam OR at no bptm errors (some other FF should catch additional issues) | ||
| ffBPTMTimeoutAndMove.i_xOK := NOT (bArbiterTimeout AND bMoveOnArbiterTimeout AND bEnable); | ||
| ffBPTMTimeoutAndMove.i_xOK := NOT (bArbiterTimeout AND bMoveOnArbiterTimeout) OR (NOT THIS^.bEnable); |
Member
There was a problem hiding this comment.
I'm rusty on my Beckhoff OOP- what do these changes do?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?
Pre-merge checklist
Always Newestversion (Library, *)pre-commitor ranpre-commit run --all-files