FIX: ignore beamclas invalid reading in NC mode#143
Merged
ghalym merged 2 commits intopcdshub:masterfrom Jan 5, 2026
Merged
Conversation
ghalym
requested review from
NSLentz and
ZLLentz
and removed request for
a team
ZLLentz
approved these changes
Dec 16, 2025
Member
ZLLentz
left a comment
ZLLentz
left a comment
There was a problem hiding this comment.
Seems like this must be correct
For my review I confirmed that nMachinemode 0 is NC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made changes to the function block that reads the SC beamclass, so it will not fault if the beamclass reading is invalid when machine is running in NC mode.
Motivation and Context
(https://jira.slac.stanford.edu/browse/ECSENG-1551)
SC beam will be in shutdown for the next year for He upgrades with its services and IOC.
One of those is the one that broadcasts the beamclass.
This was noticed yesterday when SC beam shutdown but we were still running NC. We had to bypass the fault.
How Has This Been Tested?
Where Has This Been Documented?
Pre-merge checklist
Always Newestversion (Library, *)pre-commitor ranpre-commit run --all-filesBP_IOparameters weren't modified unintentionally