Open
Conversation
this seems to be required for the HL-L2350DW, and matches the behaviour of the official driver without this, if duplex is disabled then the printer still duplexes, but every other page is garbled
QORTEC
added a commit
to QORTEC/brlaser
that referenced
this pull request
Dec 19, 2022
Contributor
|
Thanks, I've pulled your code into my fork/pull request #92. |
Author
|
Ace, thanks! |
This was referenced Dec 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be required for the HL-L2350DW, and matches the behaviour of the official driver.
Without this, if duplex is disabled then the printer still duplexes, but every other page is garbled.
I haven't tested this on any other printers. I think this should be safe (it's a standard PCL code), but it might be worth testing against other printers.
I'm using @QORTEC's master branch, but that shouldn't make any difference as the only changes are printer definitions.