fix(crypto): align Ed25519 profile verification across TS and Go#880
Merged
Conversation
7328199 to
2f49c38
Compare
2f49c38 to
6e3e7a6
Compare
6e3e7a6 to
d7813f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the TypeScript and Go reference verifiers on the PEAC Ed25519 verification profile, with shared edge-vector coverage and fail-closed runtime behavior.
The profile uses cofactorless Ed25519 verification with public-input admissibility checks for small-order public keys and unreduced signature scalars. The TypeScript implementation uses WebCrypto Ed25519 for verification and fails closed when the runtime does not support the required primitive. The Go implementation applies the same admissibility checks before stdlib verification.
Scope
ed25519-peac-profileedge-vector corpus.>=22.13.0where applicable.Compatibility
pnpm-lock.yamlis unchanged.valid: falseinstead of surfacing an untyped verifier exception.Unsupported TypeScript runtimes fail closed instead of silently using a different verifier behavior.
Verification
pnpm --filter '@peac/crypto' testpnpm --filter '@peac/protocol' testpnpm --filter '@peac/schema' testpnpm test:conformancepnpm typecheck:corepnpm verify:codegen-driftpnpm verify:registries-schemapnpm verify:no-wideningpnpm exec tsx scripts/extract-api-contract.ts --checknode scripts/conformance/generate-inventory.mjs --checkbash scripts/ci/forbid-strings.shcd sdks/go && go build ./... && go test ./... -count=1 && go test -race ./... -count=1pnpm --filter './apps/verifier' testpnpm --filter '@peac/cli' test